AstarNetwork / Astar

The dApp hub for blockchains of the future
https://astar.network/
GNU General Public License v3.0
740 stars 358 forks source link

Add more Proxy Types #760

Closed tnkshuuhei closed 1 year ago

tnkshuuhei commented 2 years ago

Description

First of all, I think it's great that added Proxy to Shibuya! Then in addition to "Any", how about adding at least the following Proxy Types as implemented in Kusama?

Why do we need?

As explained in the Polkadot wiki, "Any" is not secure. https://wiki.polkadot.network/docs/learn-proxies

Of course, there are very few cases where Proxy accounts are used in the entire Polkadot ecosystem. However, the idea of making good use of Proxy accounts to create secure Defi and Wallet could come from the ecosystem and help protect users(IMO).

Thank you

shunsukew commented 2 years ago

Thank you so much for the suggestion. Demand-based runtime improvements would be good. Since we don't have node staking, I'd like to suggest to go with Non-transfer, Governance, Cancel in Shibuya first

tnkshuuhei commented 2 years ago

Since we don't have node staking, I'd like to suggest to go with Non-transfer, Governance, Cancel in Shibuya first

@shunsukew Very nice. I believe it would be great for community

shunsukew commented 2 years ago

@tnkshuuhei Having only Any is not practical, adding basic types like NonTransfer and Cancel would be good regardless of whether we get feature requests directly from someone based on demands for actual usage in my opinion. If such proxy types are available, someone would like to make use of them. Do you have any use cases or situations where you need these proxy types, especially Governance?

tnkshuuhei commented 2 years ago

As for governance proxy, it depends on whether AstarNetwork implements on-chain governance.

Cancel Proxy may be necessary if implement a Time delayed proxy. For example, with these, we could create accounts that are resistant to hacking. (In some cases, you might use Multi-sig together, though...).

Furthermore, we might be able to develop a highly secure wallet like Argent by using it with Recovery pallet, without having to implement smart contracts. In fact, most of chains don't implement contract pallets in polkadot. but the entire polkadot ecosystem can use the wallet simply by implementing pallets in the runtime.

tnkshuuhei commented 2 years ago

These ideas are just the tip of the iceberg.

To be honest, I think the use cases for proxy are only going to increase, and there are very few Dapps that support proxy.The polkadot js UI does not support complex proxy.

shunsukew commented 1 year ago

PR merged and described proxy types will be added to Shibuya with the next runtime upgrade. DappsStaking proxy type is also added.