AstarNetwork / astar-apps

The official Astar Network portal for accessing your tokens and other native features!
https://portal.astar.network/
GNU General Public License v3.0
68 stars 86 forks source link

feat: include transaction fee into calculation of ETH balance #1220

Closed impelcrypto closed 4 months ago

impelcrypto commented 4 months ago

Pull Request Summary

Check list

This pull request makes the following changes:

Adds

=Before=

Some users seem to think the gas fee is too expensive (which appears to be a bug), but it’s just because users don’t have enough ETH, and that’s why MetaMask fails to calculate the gas fee correctly.

image

=After=

Calculate the gas fee and display error if user doesn't have ETH to pay the fee, so that MetaMask won't pop up with wrong transaction fee.

image

image

github-actions[bot] commented 4 months ago

Visit the preview URL for this PR (updated for commit bd0184a):

https://astar-apps--pr1220-feat-add-estimated-g-33uyfjdp.web.app

(expires Thu, 14 Mar 2024 15:08:04 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db