AstarNetwork / astar-apps

The official Astar Network portal for accessing your tokens and other native features!
https://portal.astar.network/
GNU General Public License v3.0
67 stars 85 forks source link

Remove dApp Staking v2 code #1283

Closed bobo-k2 closed 1 month ago

bobo-k2 commented 2 months ago

Pull Request Summary

Removed dApp staking v2 code and some other unused code. Also made adjustments to code which referenced removed code.

Things to do

Check list

github-actions[bot] commented 2 months ago

Visit the preview URL for this PR (updated for commit 85c2fc0):

https://astar-apps--pr1283-feat-staking-v2-remo-bpa8l7en.web.app

(expires Wed, 05 Jun 2024 07:59:39 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db

impelcrypto commented 1 month ago

@bobo-k2 I've resolved conflict in this commit.

bobo-k2 commented 1 month ago

@impelcrypto, @gtg7784 thank you for comments. I resleoved them in https://github.com/AstarNetwork/astar-apps/pull/1283/commits/8e31b0a9fa80b50ae1f30e8aceb0fabd5300c2dd

Kahonnohak commented 1 month ago

start checking now and found dApp news is missing 🫣

Screenshot 2024-05-15 at 15 42 42
Kahonnohak commented 1 month ago

Could you remove data from dApp news section apart from the latest 5? Keep what we can see and remove all (only promotion ones)

Screenshot 2024-05-15 at 15 45 08
bobo-k2 commented 1 month ago

Tested and it works. I think you can move the files from staking-v3 (this can be done in this or the other PR)

I will move in another PR

bobo-k2 commented 1 month ago

Could you remove data from dApp news section apart from the latest 5? Keep what we can see and remove all (only promotion ones)

@Kahonnohak thank you for comments. I fixed missing ads area. I am not sure if I get comment regarding number of dApps correctly. I changed the code to show 5 promoted and 5 new dApps. Let me know if needs to be different.

Fixed in https://github.com/AstarNetwork/astar-apps/pull/1283/commits/db3a394a52b66fb7d094be1e3c151715fe62176c