AstarNetwork / astar-apps

The official Astar Network portal for accessing your tokens and other native features!
https://portal.astar.network/
GNU General Public License v3.0
67 stars 85 forks source link

Archisinal - Dapp Staking Promo #1287

Closed Tom-STEM closed 1 month ago

Tom-STEM commented 1 month ago

Pull Request Summary

Describe what changes this pull request makes to the repository

Check list

This pull request makes the following changes:

Adds

Fixes

Changes

To-dos

*Feel free to remove this section if it's not applicable

impelcrypto commented 1 month ago

Hi Tom, could you update the Pull Request Summary?

Tom-STEM commented 1 month ago

Hi all,

Updates made.

Let me know if there are any further issues.

Thanks.

On Thu, May 23, 2024 at 1:04 AM Taegeon Alan Go @.***> wrote:

@.**** requested changes on this pull request.

In src/data/dapp_promotions.json https://github.com/AstarNetwork/astar-apps/pull/1287#discussion_r1610935360 :

@@ -47,4 +47,10 @@ "link": "https://app.moonfit.xyz/astar-reward", "img": "images/dapp_promotions/moonfit.png" } +{

  • "name": "Archisinal",
  • "shortDescription": "Pioneering Real-World-Assets in the built environment",
  • "link": "https://www.archisinal.io/",
  • "img": "images/dapp_promotions/Archisinal Logo.png"

Hi Tom, Thank you for the contributing. I just want to make same filename with others.

so, can you update image name as archisinal.png ?

— Reply to this email directly, view it on GitHub https://github.com/AstarNetwork/astar-apps/pull/1287#pullrequestreview-2072776210, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATSKL7GPDFV4DTQY4BCKYG3ZDVTFZAVCNFSM6AAAAABICMNZHCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANZSG43TMMRRGA . You are receiving this because you authored the thread.Message ID: @.***>

gtg7784 commented 1 month ago

Hi all, Updates made. Let me know if there are any further issues. Thanks. On Thu, May 23, 2024 at 1:04 AM Taegeon Alan Go @.> wrote: @*.*** requested changes on this pull request. ------------------------------ In src/data/dapp_promotions.json <#1287 (comment)> : > @@ -47,4 +47,10 @@ "link": "https://app.moonfit.xyz/astar-reward", "img": "images/dapp_promotions/moonfit.png" } +{ + "name": "Archisinal", + "shortDescription": "Pioneering Real-World-Assets in the built environment", + "link": "https://www.archisinal.io/", + "img": "images/dapp_promotions/Archisinal Logo.png" Hi Tom, Thank you for the contributing. I just want to make same filename with others. so, can you update image name as archisinal.png ? — Reply to this email directly, view it on GitHub <#1287 (review)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATSKL7GPDFV4DTQY4BCKYG3ZDVTFZAVCNFSM6AAAAABICMNZHCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANZSG43TMMRRGA . You are receiving this because you authored the thread.Message ID: @.>

Thank you! seems like image filename is changed but filename in the dapp_promotions.json is not changed yet

please take a look :)

and also, is it possible to change summary of PR?

impelcrypto commented 1 month ago

@Tom-STEM Please update Pull Request Summary above.

gtg7784 commented 1 month ago

Close this PR because of conflict between #1288 , It's outdated