AstarNetwork / astar-apps

The official Astar Network portal for accessing your tokens and other native features!
https://portal.astar.network/
GNU General Public License v3.0
67 stars 85 forks source link

Hardcode inflation period start blocks #1300

Closed bobo-k2 closed 1 month ago

bobo-k2 commented 1 month ago

Pull Request Summary

Initially I used Blockscout API to determine starting block of inflation period 1. Since Subscan started to give us "too many requests" error I decided to hardcode block number for each network since this will never change. I should do that intially.

Also reordered latest promotion card to be visible on dApp staking page

Check list

github-actions[bot] commented 1 month ago

Visit the preview URL for this PR (updated for commit b429ce3):

https://astar-apps--pr1300-fix-period1-start-pshvehop.web.app

(expires Tue, 11 Jun 2024 07:35:54 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db

impelcrypto commented 1 month ago

The % of active is not updated for Shibuya, is this an expected result? image

bobo-k2 commented 1 month ago

The % of active is not updated for Shibuya, is this an expected result?

Thanks, nice catch. The value is 0, but there was error in showing the value. Fixed in https://github.com/AstarNetwork/astar-apps/pull/1300/commits/b429ce3e2a84d5c7f33ece941340af1cf06a1cac

impelcrypto commented 1 month ago

LGTM