AstarNetwork / astar-apps

The official Astar Network portal for accessing your tokens and other native features!
https://portal.astar.network/
GNU General Public License v3.0
67 stars 85 forks source link

dApp staking v3 period 2 updates #1302

Closed bobo-k2 closed 3 weeks ago

bobo-k2 commented 1 month ago

Pull Request Summary

This PR contains

image

NOTE Staked amount and dApp earner data is currently available for Shibuya only. Astar and Shiden data indexing is in progress

image

Check list

github-actions[bot] commented 1 month ago

Visit the preview URL for this PR (updated for commit 0361f20):

https://astar-apps--pr1302-feat-dapp-staking-v3-osofs9cr.web.app

(expires Thu, 20 Jun 2024 13:40:56 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db

Kahonnohak commented 3 weeks ago

@ayumitk

Would be great If you can highlight the section 2 when user come to staking page from project page

Screenshot 2024-06-11 at 09 31 13
bobo-k2 commented 3 weeks ago

@ayumitk

Would be great If you can highlight the section 2 when user come to staking page from project page

I fixed that in commit https://github.com/AstarNetwork/astar-apps/pull/1302/commits/af7d7c94da684661ee473bbaef8ca80e9e8321c7

Kahonnohak commented 3 weeks ago

@ayumitk

Sorry for checking slow. I found two issues on mobile

1) Button doesn't have colour, is the animation not working? I do remember I had issue with the button but only had a single colour on it, did not look into it at that time. IMG_4067

2) the layout of this section is not right, have you changed anything? Please check the current layout IMG_4068

Screenshot 2024-06-12 at 16 08 53
bobo-k2 commented 3 weeks ago

@Kahonnohak I changed layout of Tier a bit (added tier threshold value) to match Figma

image
Kahonnohak commented 3 weeks ago

@bobo-k2 not the title design, but how it scrolls (to the side) it is little funny at this moment and want to have the current production scroll back. (Each tier has the box, and next box is shown on the right)

ayumitk commented 3 weeks ago
  1. Button doesn't have colour, is the animation not working? I do remember I had issue with the button but only had a single colour on it, did not look into it at that time.
  2. the layout of this section is not right, have you changed anything? Please check the current layout

@Kahonnohak @bobo-k2 I've fixed them in commit db560fd and 8df5a04.

The button animation doesn't work on mobiles, so I added the gradient background colour.

bobo-k2 commented 3 weeks ago

LGTM

Perhaps we might want to update the words in the toast.

Thank you, fixed in https://github.com/AstarNetwork/astar-apps/pull/1302/commits/06781970f096c5afcb40f61ac53dd4eab8bd88b9