AstarNetwork / astar-apps

The official Astar Network portal for accessing your tokens and other native features!
https://portal.astar.network/
GNU General Public License v3.0
68 stars 89 forks source link

fix recent history link for zkevm #1312

Closed gtg7784 closed 3 months ago

gtg7784 commented 3 months ago

Pull Request Summary

in the transaction page, link of recent history using Astar zkEVM is linked to subscan, I separate the logic of aggregate transaction history

Check list

This pull request makes the following changes:

Adds

Fixes

github-actions[bot] commented 3 months ago

Visit the preview URL for this PR (updated for commit 65d2f6d):

https://astar-apps--pr1312-fix-recent-history-z-2yxdrok4.web.app

(expires Wed, 19 Jun 2024 03:37:22 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db

gtg7784 commented 3 months ago

@gtg7784 Thanks for fixing! I think we don't need to createcastZkEVMTransferHistory and castZkEVMTransferHistory function, just use blockcsout URL if Number(networkIdx) === endpointKey.ASTAR_ZKEVM || Number(networkIdx) === endpointKey.ZKYOTO in castTransferHistory function.

image

Thanks roy, resolved with 65d2f6d commit