AstarNetwork / astar-apps

The official Astar Network portal for accessing your tokens and other native features!
https://portal.astar.network/
GNU General Public License v3.0
67 stars 85 forks source link

[Bug report] dApp staking incorrect batch construction #1338

Open Dinonard opened 1 week ago

Dinonard commented 1 week ago

Describe the bug

It seems there are certain scenarios where the portal doesn't correctly construct the batch call for dApp staking.

One such example is of an account YJWhHaMqUerTV3wsjQdfC9ybEBvGCoDUFqP8sVX3me8ti3v. This is the account state at block 6409946 (Astar):

Screenshot 2024-06-24 at 14 19 32

What we can notice is:

However, in the next block, a batch call is emitted to lock more funds: LINK

This should fail, but due to a bug in runtime it passes, and additional 70,250.00 ASTR are locked, resulting in user having more locked funds than they have ASTR. This will be fixed in runtime within day(s).

However, frontend shouldn't even construct such batch. Best case, the user should be allowed to re-lock their unlocking funds.