Add PEN and XLM tokens to Astar portal

b-yap commented 3 months ago

Pull Request Summary

Add support for PEN and XLM asset

This pull request makes the following changes:

Adds

PEN and XLM svg images
- PEN and XLM xcm transfer support
Here are the extrinsic transactions for PEN: ~https://astar.subscan.io/extrinsic/0xcacc02f33b8e6d74abb722504ae6f06e253d7d5db3891aac1f0074c8b6ca43da~ ~https://pendulum.subscan.io//extrinsic/0xaf7feb3e6b71a1f6c50964e9c44305360027678c0b9254341d6b0ccfd6b83553~

~Test for minimum 0.1 PEN:~ ~https://pendulum.subscan.io//extrinsic/0xfbdd784f2eb845a952a0fefcf5ae76428b42bd4eeffd43936f00e38d768eaafb~ Extrinsic transactions of PEN token in order:

Pendulum -> Astar: https://pendulum.subscan.io//extrinsic/0xcbfcc457735560cb384a0cca7f7f22cc90151b3f993629f77adf2fa825867e16
Pendulum -> Astar: https://pendulum.subscan.io//extrinsic/0x59f0cd5a585ff03d9ebcc9ab3c456e588b0558b1f2788e45b0b6456b074069ae
Astar to Pendulum: https://astar.subscan.io/extrinsic/0x6d4db503dc5ca31e33a0ac9a7770dca92594ec3dea2b65d9dfd78e32b792bdc2

Extrinsic transactions of XLM token in order:

Pendulum -> Astar: https://pendulum.subscan.io//extrinsic/0xd7218b8cb97ae3e37f7279d8eba8a5d692400cfbc789c7982a667ec1c9fa3559
Astar -> Pendulum: https://astar.subscan.io/extrinsic/0xf3ee84928dcfde37d0aa5530c89e438513d1877d04c13cd5a48a4b7e0105ed91
Pendulum to Astar: https://pendulum.subscan.io//extrinsic/0x3e403c13d74189c8e8a38cfc6a6ad8b0c83180a15d44adae728a94dc5aa9bd45

Vercel URL: ~astar-apps-b-yap-bs-projects-fe8df2be.vercel.app~ https://astar-apps-bs-projects-fe8df2be.vercel.app/

bobo-k2 commented 2 months ago

Thank you for the PR. Please send some test tokens to XLoLJBQoMPHMLXYhdFobSpH5GujRoUH8d1sUtaEtoBG7zaS

gtg7784 commented 2 months ago

Hi @b-yap ! Thank you for contribute on our portal, can you send me PEN and XLM for testing it?

This is my Astar wallet address WGeDwTxHVMnbzNS7xkKsxfrabvimPkF96eBa7uYYbTDzNiG

Thank you :)

b-yap commented 2 months ago

@bobo-k2 @gtg7784 Should I send test tokens to both accounts: XLoLJBQoMPHMLXYhdFobSpH5GujRoUH8d1sUtaEtoBG7zaS WGeDwTxHVMnbzNS7xkKsxfrabvimPkF96eBa7uYYbTDzNiG ?

Or any of these 2?

gtg7784 commented 2 months ago

@bobo-k2 @gtg7784 Should I send test tokens to both accounts: XLoLJBQoMPHMLXYhdFobSpH5GujRoUH8d1sUtaEtoBG7zaS WGeDwTxHVMnbzNS7xkKsxfrabvimPkF96eBa7uYYbTDzNiG ?

Or any of these 2?

Please send it to both, We want to test it on each environment.

Thank you :)

b-yap commented 2 months ago

@gtg7784 XLM tokens transferred: https://pendulum.subscan.io/xcm_message/polkadot-a01b30d8091ec0b61088d9ca2550049e55ba3bcc https://pendulum.subscan.io/xcm_message/polkadot-3bb12bfa4fdb443eb5d38f444236875a33a10c84

b-yap commented 2 months ago

@gtg7784 PEN tokens transferred: https://pendulum.subscan.io/xcm_message/polkadot-f1e76d4e05b44b43fedafbfc4e0ab8a51028edd0 https://pendulum.subscan.io/xcm_message/polkadot-b5ac12dd1ed6ef510e948cff74d255df1d36d337

bobo-k2 commented 2 months ago

After selecting Pendulum network

XCM component dissapears. This doesn't happen for other networks. I don't see any error in console

b-yap commented 2 months ago

@bobo-k2 I have redeployed with a new vercel URL using the updated change: ~https://astar-apps-jnrb64nyx-bs-projects-fe8df2be.vercel.app/~. https://astar-apps-b-yap-bs-projects-fe8df2be.vercel.app/ The problem was the token name. I set it as PEN, but it's actually defined as xcPEN in Astar.

bobo-k2 commented 2 months ago

Hi @b-yap the new Vercel URL is asking me to authenticate, can you fix that?

b-yap commented 2 months ago

@bobo-k2 sorry for that. Updated: https://astar-apps-b-yap-bs-projects-fe8df2be.vercel.app/

bobo-k2 commented 2 months ago

When I started testing I had 3 xcPEN on Pendulum. After that I made two transactions from Astar to Pendulum and UI is still showing 3 xcPEN https://astar.subscan.io/extrinsic/0x7c1352ba3daba47a01ff1c7831c7880fd73cc56c8b6e6cce469ae85d61cc088d https://astar.subscan.io/extrinsic/0xba4004fccbf2e0c064f0f9950e287de7f9fe90a177bdbd01062a1537039b6896

I transfered 1 XLM.s from Astar to Pendulum and UI still showing 0 XML.s on Pendulum https://astar.subscan.io/extrinsic/0xff7e7c92686805d76377c7b78919951db82e186f561a567f77a86226911fd0b2

After reloading the portal shows 0.042 XML.s?!

b-yap commented 2 months ago

Moving this to draft, for now.

We identified that the minimum transfer amounts we use so far are not large enough to cover the XCM transfer fees charged on Pendulum. We are currently discussing which values we should use and will update the PR accordingly.

b-yap commented 2 months ago

XLM transfer: Beginning amounts:

Result after transferring 1.01 XLM Pendulum -> Astar

Result after transferring 1.1 XLM Astar -> Pendulum

Result after transferring 1 XLM Pendulum -> Astar

b-yap commented 2 months ago

PEN transfer: Beginning amounts:

Result after transferring 2.01 PEN Pendulum -> Astar:

Result after transferring 2 PEN Pendulum -> Astar:

Result after transferring 2.5 PEN Astar -> Pendulum:

b-yap commented 2 months ago

@bobo-k2 We have increased the minimum transferred amounts, thus gave you more XLMs and PENs to play with. Vercel link: https://astar-apps-bs-projects-fe8df2be.vercel.app/

bobo-k2 commented 1 month ago

Hi @b-yap and thank you for the update. Another problem arise in the meantime. I believe this happens because outdated polkadot.js version. Please merge main into your branch. We uplifted polkadot.js to the latest version recently.