AstarNetwork / astar-frame

Core frame modules for Astar & Shiden network.
Other
58 stars 38 forks source link

dApps staking max encoded len #106

Closed Dinonard closed 1 year ago

Dinonard commented 1 year ago

Pull Request Summary

Removes without_storage_info from the pallet-dapps-staking crate. Introduces derivation of MaxEncodedLen trait to all possible structs, enums and types.

For the UnbondingInfo and StakerInfo, an assumption is introduced that their length won't go over a specific constant. Since we're fully in control of runtime code, we can be fairly sure this limitation won't be exceeded. Also, dApps staking is a stable feature and there is no reason to modify current parameters from what they currently are.

See code more more detailed explanation & comments.

github-actions[bot] commented 1 year ago

Code Coverage

Package Line Rate Branch Rate Health
chain-extensions/trait/src 0% 0%
frame/xc-asset-config/src 70% 0%
precompiles/utils/macro/tests 0% 0%
precompiles/utils/src/data 72% 0%
precompiles/utils/src 72% 0%
frame/pallet-xcm/src 65% 0%
precompiles/xcm/src 84% 0%
primitives/xcm/src 68% 0%
chain-extensions/rmrk/src 0% 0%
frame/pallet-xvm/src/pallet 37% 0%
precompiles/sr25519/src 79% 0%
precompiles/xvm/src 89% 0%
chain-extensions/types/rmrk/src 0% 0%
frame/dapps-staking/src/pallet 90% 0%
chain-extensions/xvm/src 0% 0%
precompiles/utils/macro/src 0% 0%
frame/pallet-xvm/src 9% 0%
frame/block-reward/src 85% 0%
chain-extensions/types/xvm/src 0% 0%
chain-extensions/types/dapps-staking/src 0% 0%
contracts/xvm/src 0% 0%
frame/collator-selection/src 80% 0%
frame/custom-signatures/src 57% 0%
chain-extensions/dapps-staking/src 0% 0%
frame/dapps-staking/src 83% 0%
precompiles/assets-erc20/src 73% 0%
precompiles/dapps-staking/src 93% 0%
precompiles/substrate-ecdsa/src 78% 0%
Summary 60% (2572 / 4290) 0% (0 / 0)

Minimum allowed line rate is 50%