AstarNetwork / astar-frame

Core frame modules for Astar & Shiden network.
Other
58 stars 38 forks source link

Prevent double & incorrect charging of EVM-XVM gas fee #115

Closed Dinonard closed 1 year ago

Dinonard commented 1 year ago

Pull Request Summary

By specifying max_fee_per_gas to be zero, we instruct EVM executor not to charge the caller for gas fees.

This is ok since the XVM call will be charged in the context of its originating call.

EVM runner reference code: https://github.com/paritytech/frontier/blob/master/frame/evm/src/runner/stack.rs#L135

github-actions[bot] commented 1 year ago

Code Coverage

Package Line Rate Branch Rate Health
precompiles/xcm/src 84% 0%
chain-extensions/xvm/src 0% 0%
frame/pallet-xvm/src 11% 0%
precompiles/substrate-ecdsa/src 78% 0%
precompiles/xvm/src 94% 0%
frame/collator-selection/src 80% 0%
frame/xc-asset-config/src 70% 0%
precompiles/assets-erc20/src 73% 0%
frame/dapps-staking/src/pallet 90% 0%
precompiles/dapps-staking/src 93% 0%
precompiles/utils/src 72% 0%
primitives/xcm/src 68% 0%
chain-extensions/dapps-staking/src 0% 0%
frame/pallet-xcm/src 65% 0%
frame/pallet-xvm/src/pallet 34% 0%
chain-extensions/types/xvm/src 0% 0%
chain-extensions/rmrk/src 0% 0%
chain-extensions/types/dapps-staking/src 0% 0%
chain-extensions/types/rmrk/src 0% 0%
precompiles/sr25519/src 79% 0%
frame/dapps-staking/src 83% 0%
precompiles/utils/macro/src 0% 0%
frame/block-reward/src 85% 0%
precompiles/utils/macro/tests 0% 0%
precompiles/utils/src/data 72% 0%
frame/custom-signatures/src 57% 0%
Summary 59% (2582 / 4343) 0% (0 / 0)

Minimum allowed line rate is 50%