Closed shunsukew closed 1 year ago
Noticed that collator_selection pallet weights has obvious difference especially new_session
.
@akru Do you have any idea? (MaxCandidates for benchmarking are changed to from 999
to 148
)
Package | Line Rate | Branch Rate | Health |
---|---|---|---|
chain-extensions/rmrk/src | 0% | 0% | ❌ |
frame/block-reward/src | 82% | 0% | ✔ |
frame/pallet-xvm/src/pallet | 33% | 0% | ❌ |
frame/pallet-xvm/src | 11% | 0% | ❌ |
precompiles/dapps-staking/src | 93% | 0% | ✔ |
precompiles/utils/macro/src | 0% | 0% | ❌ |
precompiles/utils/src | 72% | 0% | ➖ |
frame/custom-signatures/src | 54% | 0% | ➖ |
frame/xc-asset-config/src | 67% | 0% | ➖ |
chain-extensions/types/xvm/src | 0% | 0% | ❌ |
chain-extensions/dapps-staking/src | 0% | 0% | ❌ |
precompiles/utils/macro/tests | 0% | 0% | ❌ |
precompiles/substrate-ecdsa/src | 78% | 0% | ➖ |
precompiles/xvm/src | 94% | 0% | ✔ |
chain-extensions/types/rmrk/src | 0% | 0% | ❌ |
frame/dapps-staking/src/pallet | 87% | 0% | ✔ |
frame/pallet-xcm/src | 64% | 0% | ➖ |
precompiles/assets-erc20/src | 73% | 0% | ➖ |
precompiles/utils/src/data | 72% | 0% | ➖ |
frame/dapps-staking/src | 89% | 0% | ✔ |
precompiles/sr25519/src | 79% | 0% | ➖ |
precompiles/xcm/src | 84% | 0% | ✔ |
chain-extensions/types/dapps-staking/src | 0% | 0% | ❌ |
frame/collator-selection/src | 80% | 0% | ✔ |
primitives/xcm/src | 66% | 0% | ➖ |
chain-extensions/xvm/src | 0% | 0% | ❌ |
Summary | 60% (2583 / 4311) | 0% (0 / 0) | ➖ |
Minimum allowed line rate is 50%
I guess this value comes from some default setting.
I see, thank you
Pull Request Summary Optimize custom pallets' weights by using benchmark machine as is already done for DappsStaking pallets https://github.com/AstarNetwork/astar-frame/pull/122
Target pallets
Machine spec used
machine bench result