AstarNetwork / astar-frame

Core frame modules for Astar & Shiden network.
Other
58 stars 38 forks source link

disabled proof size in pre-charging #153

Closed akorchyn closed 1 year ago

akorchyn commented 1 year ago

Pull Request Summary Disabled proof size usage in pre-charging because it's impossible to make a reset later on.

This causes the wrong estimation in polkadot js and also may cause "exhaust block limit"

Check list

akorchyn commented 1 year ago

Hey, @Dinonard.

Sorry for the ping. Any change to get a review on it?

Dinonard commented 1 year ago

Hey, @Dinonard.

Sorry for the ping. Any change to get a review on it?

Hi @akorchyn,

if PoV size isn't refundable, replace it with some constant

akorchyn commented 1 year ago

It couldnt make a comment in pr, so probably fine, I guess?

Also, I have created new PR for frontier we repo: https://github.com/AstarNetwork/frontier/pull/84 I would appreciate if you could look as well

Dinonard commented 1 year ago

It couldnt make a comment in pr, so probably fine, I guess?

Also, I have created new PR for frontier we repo: AstarNetwork/frontier#84 I would appreciate if you could look as well

Sure, please just make the CI pass.

akorchyn commented 1 year ago

It couldnt make a comment in pr, so probably fine, I guess? Also, I have created new PR for frontier we repo: AstarNetwork/frontier#84 I would appreciate if you could look as well

Sure, please just make the CI pass.

Error: Resource not accessible by integration. Not sure it's issue on my side. Probably CI component is out. The tests passed itself

Can you retrigger the failed job

Dinonard commented 1 year ago

It couldnt make a comment in pr, so probably fine, I guess? Also, I have created new PR for frontier we repo: AstarNetwork/frontier#84 I would appreciate if you could look as well

Sure, please just make the CI pass.

Error: Resource not accessible by integration. Not sure it's issue on my side. Probably CI component is out. The tests passed itself

Can you retrigger the failed job

Right! I will let our dev ops team know.