Closed Dinonard closed 1 year ago
Looks good in general!
I wonder why we are using
DispatchResultWithPostInfo
as the return type though there is no post info?
Thanks!
For the DispatchResultWithPostInfo
you're right that it's not needed. I just copied it from the previous pallet for the first extrinsic I added, then reused it afterwards 😁. Fixed it now.
All functionality intended for this PR has been implemented, and it's ready for final review 🙏
Package | Line Rate | Branch Rate | Health |
---|---|---|---|
chain-extensions/types/assets/src | 0% | 0% | ❌ |
chain-extensions/pallet-assets/src | 0% | 0% | ❌ |
frame/pallet-xcm/src | 53% | 0% | ➖ |
chain-extensions/types/xvm/src | 0% | 0% | ❌ |
frame/pallet-xvm/src | 5% | 0% | ❌ |
frame/pallet-xvm/src/pallet | 8% | 0% | ❌ |
precompiles/xvm/src | 61% | 0% | ➖ |
primitives/xcm/src | 62% | 0% | ➖ |
precompiles/sr25519/src | 79% | 0% | ➖ |
precompiles/substrate-ecdsa/src | 78% | 0% | ➖ |
frame/block-reward/src | 80% | 0% | ✔ |
frame/collator-selection/src | 76% | 0% | ➖ |
frame/contracts-migration/src | 0% | 0% | ❌ |
frame/xc-asset-config/src | 50% | 0% | ➖ |
precompiles/dapps-staking/src | 93% | 0% | ✔ |
precompiles/utils/src | 69% | 0% | ➖ |
precompiles/xcm/src | 85% | 0% | ✔ |
precompiles/assets-erc20/src | 76% | 0% | ➖ |
precompiles/utils/macro/tests | 0% | 0% | ❌ |
precompiles/utils/macro/src | 0% | 0% | ❌ |
frame/dapps-staking/src/pallet | 87% | 0% | ✔ |
frame/dapp-staking-v3/src/test | 0% | 0% | ❌ |
chain-extensions/xvm/src | 0% | 0% | ❌ |
chain-extensions/types/dapps-staking/src | 0% | 0% | ❌ |
frame/dapp-staking-v3/src | 85% | 0% | ✔ |
chain-extensions/dapps-staking/src | 0% | 0% | ❌ |
frame/custom-signatures/src | 52% | 0% | ➖ |
frame/dapps-staking/src | 82% | 0% | ✔ |
Summary | 57% (2819 / 4916) | 0% (0 / 0) | ➖ |
Minimum allowed line rate is 50%
@shaunxw thanks for the approval!
I was thinking, instead of merging it directly, to keep this in a 'live' branch. All consecutive PRs would be merged to this branch instead (or I could create another branch to aggregate all PRs).
This would keep the review of PRs light(er), while also providing one big overview in the end, before everything is merged. What do you think?
Love this idea. It definitely helps with the review process.
Pull Request Summary
First PR that will introduce part of dApps staking v3 functionality. Overall implementation will be broken down into multiple PRs to make it easier for reviewers.
Part 1
After receiving first review, will amend the comments and implement extensive unit tests.
Check list