Remove unused storage items

AstarNetwork / astar-frame

Core frame modules for Astar & Shiden network.

Other

58 stars 38 forks source link

Remove unused storage items #34

Closed Dinonard closed 2 years ago

Dinonard commented 2 years ago

Pull Request Summary

Removes unused storage items from pallet-dapps-staking. We don't need to bring these to Astar chain.

Migration code was kept for future reference. We can remove it later if needed.

Check list

[ ] contains breaking changes
[ ] adds new feature
[x] modifies existing feature (bug fix or improvements)
[ ] relies on other tasks
[ ] documentation changes
[ ] tests and/or benchmarks are included
[ ] changed API client type definition or chain metadata

codespool commented 2 years ago

Looks good. Can you just explain what's the reason to comment out all the unusable code instead of deleting it?

Dinonard commented 2 years ago

Looks good. Can you just explain what's the reason to comment out all the unusable code instead of deleting it?

Please see PR summary.

codespool commented 2 years ago

Please see PR summary. 🤦 oh, right, my bad, sorry

Dinonard commented 2 years ago

Please see PR summary. facepalm oh, right, my bad, sorry

It's fine! xD

Fortunately, I've tagged PRs with storage migration so we can easily find them. Let's get rid of migration code in some future PR just so we keep the size of current one as small as possible.