Added pallet-xcm with reserve withdraw function - Githubissues

AstarNetwork / astar-frame

Core frame modules for Astar & Shiden network.

Other

58 stars 38 forks source link

Added pallet-xcm with reserve withdraw function #55

Closed akru closed 2 years ago

akru commented 2 years ago

Pull Request Summary Technically its fork of Polkadot pallet-xcm with new function to withdraw reserve transfers.

This PR introduces two methods:

reserveWithdrawAssets()
limitedReserveWithdrawAssets()

Both has same arguments as reserveTransfer*** methods, but do reverse action: withdraw asset from reserve, for example, relay chain.

Check list

[ ] contains breaking changes
[x] adds new feature
[ ] modifies existing feature (bug fix or improvements)
[ ] relies on other tasks
[ ] documentation changes
[ ] tests and/or benchmarks are included
[ ] changed API client type definition or chain metadata

This pull request makes the following changes:

Adds

(ex: Add feature A)

Fixes

(ex: Fix validation function)

Changes

(ex: Change document B)

To-dos

*Feel free to remove this section if it's not applicable

[ ] (ex: add user list)

akru commented 2 years ago

@Dinonard reworked

hoonsubin commented 2 years ago

Should we also consider adding https://github.com/PureStake/moonbeam/blob/571e842db30fe25d550ae20ea23b3078906a21fc/precompiles/xcm_transactor/XcmTransactor.sol so users can withdraw from EVM?