Individual Claim

[Dinonard]

Pull Request Summary

Main purpose of this commit is to solve scalability problems with the former claim implementation. Instead of using group claims, each staker will now be responsible for claiming their own rewards.

This entails changes in storage schema and other extrinsic calls.

• dApp state is now tracked using a dedicated enum DAppState
• Cleaned Forcing enum of unused values
• EraStakingPoints now contains info about staked value, number of stakers and whether dapp rewards were claimed for an era
• StakerInfo is a new struct which handles (staker, contract) info storage in a scalable manner
  • the idea is to wrap history into a vector of limited size which prevents stakers from overflowing our DB
  • methods are available for easier handling, extensive and thorough UTs provided
  • Introduced RewardHandling enum as preparation for future task (to avoid storage migration)
  • HistoryDepth limit has been removed
  • BonusEraDuration has been removed as it serves no purpose anymore
  • New extrinsic withdraw_from_unregistered to cleanup stakes after contract was removed
  • claiming functionality now has separate calls for claim_staker and claim_dapp
  • very extensive UTs provided

TODO

• [x] rename EraStakeAndReward to something more appropriate
• [x] manual test on local node
• [x] update precompiles code
• [x] update documentation (README)
• [x] re-run all benchmarks prior to merge
• [x] implement new benchmarking
• [x] implement & test storage migration
• [x] cover code with UTs
• [x] implement individual claim

Check list

• [x] contains breaking changes
• [x] adds new feature
• [x] modifies existing feature (bug fix or improvements)
• [ ] relies on other tasks
• [ ] documentation changes
• [x] tests and/or benchmarks are included
• [ ] changed API client type definition or chain metadata

[codespool]

Found this while fixing my own PR: you're still using reward_handling property name in migrations: https://github.com/AstarNetwork/astar-frame/blob/6df33856f0616fcecf21e5bb593a444961c9bbe5/frame/dapps-staking/src/migrations.rs#L548 is that intentional?

[Dinonard]

Found this while fixing my own PR: you're still using reward_handling property name in migrations:

https://github.com/AstarNetwork/astar-frame/blob/6df33856f0616fcecf21e5bb593a444961c9bbe5/frame/dapps-staking/src/migrations.rs#L548

is that intentional?

Oh, I didn't rename the variable name. I will do it now. The type is RewardDestination though, even here.

[Dinonard]

@codespool You can rebase on the default branch now. No more force-pushes :D