AstarNetwork / astar-frame

Core frame modules for Astar & Shiden network.
Other
58 stars 38 forks source link

Recover Erc20AssetsPrecompileSet new function #75

Closed shunsukew closed 2 years ago

shunsukew commented 2 years ago

Pull Request Summary new function was failing lint check, thus it was removed in the former PR. Instead, Default derive was added. https://github.com/AstarNetwork/astar-frame/pull/73/files#diff-a57fe059e97a2348d92ca778296fda9d73e137ca1dd8692e164451509b62401dL180

However, Runtime side was using new function and cannot compile if dependency updated, so we should recover it.

Screen Shot 2022-07-14 at 20 58 29
github-actions[bot] commented 2 years ago

Code Coverage

Package Line Rate Branch Rate Health
frame/pallet-xcm/src 80% 0%
primitives/xcm/src 88% 0%
precompiles/utils/src/data 73% 0%
frame/dapps-staking/src 94% 0%
precompiles/assets-erc20/src 91% 0%
precompiles/utils/macro/tests 100% 0%
frame/custom-signatures/src 80% 0%
frame/dapps-staking/src/pallet 90% 0%
precompiles/utils/macro/src 0% 0%
precompiles/utils/src 84% 0%
precompiles/xcm/src 78% 0%
frame/vesting/src 87% 0%
precompiles/dapps-staking/src 95% 0%
frame/block-reward/src 96% 0%
frame/collator-selection/src 89% 0%
frame/xc-asset-config/src 88% 0%
precompiles/substrate-ecdsa/src 78% 0%
precompiles/sr25519/src 78% 0%
Summary 88% (8362 / 9527) 0% (0 / 0)

Minimum allowed line rate is 60%