github-actions[bot]
commented
2 years ago 
| Package | Line Rate | Branch Rate | Health |
|---|---|---|---|
| frame/vesting/src | 87% | 0% | ✔ |
| precompiles/assets-erc20/src | 91% | 0% | ✔ |
| frame/block-reward/src | 96% | 0% | ✔ |
| precompiles/utils/macro/tests | 100% | 0% | ✔ |
| precompiles/dapps-staking/src | 95% | 0% | ✔ |
| frame/dapps-staking/src/pallet | 90% | 0% | ✔ |
| frame/xc-asset-config/src | 88% | 0% | ✔ |
| precompiles/utils/src/data | 72% | 0% | ➖ |
| precompiles/utils/macro/src | 0% | 0% | ❌ |
| precompiles/utils/src | 83% | 0% | ✔ |
| frame/dapps-staking/src | 94% | 0% | ✔ |
| primitives/xcm/src | 88% | 0% | ✔ |
| precompiles/sr25519/src | 78% | 0% | ➖ |
| frame/pallet-xcm/src | 80% | 0% | ➖ |
| frame/collator-selection/src | 89% | 0% | ✔ |
| precompiles/substrate-ecdsa/src | 78% | 0% | ➖ |
| precompiles/xcm/src | 80% | 0% | ➖ |
| frame/custom-signatures/src | 80% | 0% | ➖ |
| Summary | 88% (8375 / 9544) | 0% (0 / 0) | ✔ |
Minimum allowed line rate is 60%
Pull Request Summary
Adds support for ETH-style address to the XCM-precompile's withdraw function. Legacy interface remains unchanged, instead a new function is added, as recommended.
One drawback to the current solution is that both H160 and SS58 are encoded as 256 bits. This can be problematic since we cannot detect if user incorrectly withdraw for SS58 with H160 as beneficiary.
Check list