AstarNetwork / astar.js

Astar network Typescript SDK
Apache License 2.0
30 stars 9 forks source link

feat: added util functions #30

Closed impelcrypto closed 1 year ago

impelcrypto commented 1 year ago
impelcrypto commented 1 year ago

Hi @niklabh I got this error when I run yarn build (and the warnings will appear on the frontend app). Could you take a look? 🙏

image
impelcrypto commented 1 year ago

Hi @niklabh It seems like functions exported from astar-js won't come with type annotation. Could you help take a look?

= examples = For this, capitalize should returns string

Astar-js image

Astar Portal

image

For this, I'd like to avoid adding typeof in front of the type/interface imported from astar-js

Astar Portal

image
impelcrypto commented 1 year ago

Hi @niklabh I've resolved type annotation issue (in this line).

impelcrypto commented 1 year ago

@niklabh Please keep check this issue.

impelcrypto commented 1 year ago

@niklabh Not sure if this commit makes sense to you but it looks like the version issue has been resolved.

  1. It looks like build, test and lint are failed, could you take a look? I think there still have a version issue (you can check with yarn test)
  2. Do you know why yarn upgrade --pattern @polkadot --latest doesn't work in this repo?
image
impelcrypto commented 1 year ago

@niklabh

  1. I've update pr-any.yml in this commit, please take a look. Still getting an error in build checks in CI.
  2. After updated Polkadot.js packages, some code doesn't work properly. You may want to check these files.

https://github.com/AstarNetwork/astar.js/actions/runs/3926818642/jobs/6712929764

https://github.com/AstarNetwork/astar.js/pull/30/commits/685d935a1b4fa3a1ec045920a63f63ef0620622e