AstarNetwork / astar.js

Astar network Typescript SDK
Apache License 2.0
30 stars 9 forks source link

Add final rewards+final used fee #75

Open johnnyji-dev opened 4 months ago

gtg7784 commented 1 month ago

Hi @johnnyji-dev thank you for your contribution. Can you please add the PR dscription?

johnnyji-dev commented 1 month ago

Hi @johnnyji-dev thank you for your contribution. Can you please add the PR dscription?

Is there any template for PR description? Is there no format? Can I just write down description for my PR? BTW, I checked out my PR and it need to update on "claimedReward" method.

I completed to update and test that method. I am going to retry to PR.

gtg7784 commented 1 month ago

Hi @johnnyji-dev thank you for your contribution. Can you please add the PR dscription?

Is there any template for PR description? Is there no format? Can I just write down description for my PR? BTW, I checked out my PR and it need to update on "claimedReward" method.

I completed to update and test that method. I am going to retry to PR.

Hi, you can write summary of updates in this PR without template.

Please update the description and check that claimedReward method (and why it's needed)

thank you for your contribution.

gtg7784 commented 1 month ago

and also, please run lint before commit your updates. thank you

johnnyji-dev commented 1 month ago

@gtg7784 [Adding Two Methods]

It need to merge the commit (77dc1cec6fb9c32a32c7820c0aacc1cecdb08e24).

bobo-k2 commented 2 weeks ago

Hi @johnnyji-dev on more thing. Can you please uplift version in package.json (there are multiple files) from 0.2.9 to 0.3.0

johnnyji-dev commented 1 week ago

Hi @johnnyji-dev on more thing. Can you please uplift version in package.json (there are multiple files) from 0.2.9 to 0.3.0

@bobo-k2 Monosnap package json — astar js  개발 컨테이너: Alpine @ desktop-linux  2024-06-23 16-56-06

I uplifted version in package.json (there are multiple files) to 0.3.0