Open hoonsubin opened 3 years ago
@LRUki can I tackle these 2 tasks if you're busy to working on params thing? :
allow the user to upload the metadata.json file instead of pasting the full JSON string when adding a contract code hash and switch the location for the bundle name and code hash input box
change the balance input component format for Endowment (UNIT) and Max gas allowed so that it matches the style of ones in the Transfer <Token> modal. The input box should allow the users to choose a different token metric or use decimal strings
The two tasks below have been completed. do I know what's the current status about first task? @LRUki @hoonsubin
@sirius651 from what I know, @LRUki is currently working on the input formatting but not the message sending logic yet. What is your estimate for implementing it? If it's not too difficult, I think you can go ahead with the implementation.
@hoonsubin alright, I'll hop on that after resolving PR #43
Task Summary
Currently, we cannot provide any arguments for the contract
constructor
method from theModalCreateDapps.vue
component. We should allow the user to pass the arguments (even if it's just in raw string input that is converted inside the app) when instantiating a new contract. Additionally, when we want to add a contract from a code hash, we need to provide themetadata.json
(ABI) file for it. Right now it only accepts raw string input, but let's improve this so that the user can upload thejson
file directly.Task List
[x] allow users to input contract constructor arguments when instantiating a new contract (the
new
method) https://github.com/PlasmNetwork/plasm-apps-vue/blob/45381bafb72eabba103bff0cae0b12a9dba092c2/src/components/dapps/ModalCreateDapps.vue#L288[ ] allow users to pass arguments for contract methods or fetch contract stores. We may want to create a contract modal that renders all interactable messages if we want this feature to be extendible. If this task takes too long, we'll separate this into its own issue and skip this one for the initial launch.
[x] change the balance input component format for
Endowment (UNIT)
andMax gas allowed
so that it matches the style of ones in theTransfer <Token>
modal. The input box should allow the users to choose a different token metric or use decimal strings https://github.com/PlasmNetwork/plasm-apps-vue/blob/45381bafb72eabba103bff0cae0b12a9dba092c2/src/components/dapps/ModalCreateDapps.vue#L140[x] allow the user to upload the
metadata.json
file instead of pasting the full JSON string when adding a contract code hash and switch the location for the bundle name and code hash input box https://github.com/PlasmNetwork/plasm-apps-vue/blob/45381bafb72eabba103bff0cae0b12a9dba092c2/src/components/dapps/ModalCodeHash.vue#L55