AstarNetwork / plasm-apps-vue

The front-end application for Plasm Network
https://portal.astar.network/
3 stars 3 forks source link

Improve ink smart contract instantiation and code hash metadata upload feature #32

Open hoonsubin opened 3 years ago

hoonsubin commented 3 years ago

Task Summary

Currently, we cannot provide any arguments for the contract constructor method from the ModalCreateDapps.vue component. We should allow the user to pass the arguments (even if it's just in raw string input that is converted inside the app) when instantiating a new contract. Additionally, when we want to add a contract from a code hash, we need to provide the metadata.json (ABI) file for it. Right now it only accepts raw string input, but let's improve this so that the user can upload the json file directly.

Task List

sirius651 commented 3 years ago

@LRUki can I tackle these 2 tasks if you're busy to working on params thing? : allow the user to upload the metadata.json file instead of pasting the full JSON string when adding a contract code hash and switch the location for the bundle name and code hash input box

change the balance input component format for Endowment (UNIT) and Max gas allowed so that it matches the style of ones in the Transfer <Token> modal. The input box should allow the users to choose a different token metric or use decimal strings

sirius651 commented 3 years ago

The two tasks below have been completed. do I know what's the current status about first task? @LRUki @hoonsubin

hoonsubin commented 3 years ago

@sirius651 from what I know, @LRUki is currently working on the input formatting but not the message sending logic yet. What is your estimate for implementing it? If it's not too difficult, I think you can go ahead with the implementation.

sirius651 commented 3 years ago

@hoonsubin alright, I'll hop on that after resolving PR #43