AstarVienna / METIS_Simulations

Scripts for simulating METIS with ScopeSim
1 stars 0 forks source link

Fixed bug running lss_l mode #17

Closed JenniferKarr closed 5 months ago

JenniferKarr commented 5 months ago

Fixed issue with MODESDICT mapping both lss_l and lss_m to tech of LSS,LM.

This resulted in the code running for an open filter, but producing the wrong band, and crashing when trying to apply a filter, as the wavelength coverage became empty.

Fixed by using the "mode" line in the recipes.yaml file to set the mode directly, and adding a -m --mode option to the arg parser for the raw_script.py command line module. We may want add some error trapping to catch inconsistent mode/tech keywords.

hugobuddel commented 5 months ago

I've approved the PR @JenniferKarr, so you can merge it, or you can apply the suggestions I made.

I'll go ahead and merge it, so we can also merge the other PRs