search

AstarVienna / METIS_Simulations

Scripts for simulating METIS with ScopeSim
1 stars 0 forks source link

Taking care the case of "no argument was passed" #9

Closed chyan26 closed 4 months ago

chyan26 commented 7 months ago

I was playing with raw_script.py, I got the following error message

chyan@zeus:~/METIS_Simulations/ESO$ python raw_script.py
Traceback (most recent call last):
  File "/home/chyan/METIS_Simulations/ESO/raw_script.py", line 328, in <module>
    main()
  File "/home/chyan/METIS_Simulations/ESO/raw_script.py", line 294, in main
    noexpcy = [cycle(arg) for arg in argdict.values()]
               ^^^^^^^^^^
TypeError: 'NoneType' object is not iterable

I guess this script needs to take care the case when there is no argument is passed.

teutoburg commented 7 months ago

I see you addressed this already in 3407b0a. FWIW, I kinda stopped further development of raw_script.py in favor of the simpler, YAML-based run_recipes.py. Which doesn't mean the former is a dead-end, but for now I'm more focused on moving forward with the latter.

hugobuddel commented 7 months ago

Still good to have the script do something sensible when ran without arguments; I noticed it too, so thanks for fixing it. I guess we can close this issue now right?

@chyan26 could you please create a pull request instead of committing directly to main? Even for small changes it is useful to follow a bit of a process and it takes little effort. We couldn't really have such a workflow for the DRLD because there were people directly editing overleaf anyway.

Perhaps in one of next weeks meetings we can discuss what workflow we want for our METIS repositories.