search

AstarVienna / ScopeSim

A telescope observation simulator for Python.
GNU General Public License v3.0
14 stars 10 forks source link

Enlarge initial Field of View to suppord wide-field imagers #433

Closed hugobuddel closed 3 months ago

hugobuddel commented 3 months ago

100 square degree should be enough for everyone! Survey telescopes can have a large Field of View though:

There should be no negative effects for having a large initial field of view, because it is immediately reduced to the actual field of view of the instrument upon initialization of the OpticalTrain.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.32%. Comparing base (a3ee3f1) to head (e9a286a). Report is 125 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #433 +/- ## ======================================= Coverage 75.32% 75.32% ======================================= Files 56 56 Lines 7821 7821 ======================================= Hits 5891 5891 Misses 1930 1930 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

hugobuddel commented 3 months ago

I'm not sure whether this will break anything in the IRDB.. All the tests pass, but didn't run all the notebooks. Let's see.

hugobuddel commented 3 months ago

Seems ScopeSim_Data ran fine last night.