search

AstarVienna / ScopeSim

A telescope observation simulator for Python.
GNU General Public License v3.0
16 stars 10 forks source link

Workaround for #491 metadata.requires can return None #492

Closed hugobuddel closed 2 weeks ago

hugobuddel commented 2 weeks ago

Closes #491 . Or well, ensures that bug_report() does not crash. We could perhaps do something smarter like log an error or so, maybe we can do that if the problem appears more often.

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.70%. Comparing base (7fcc509) to head (b2c60c6). Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
scopesim/utils.py 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #492 +/- ## ========================================== - Coverage 76.71% 76.70% -0.01% ========================================== Files 66 66 Lines 8121 8123 +2 ========================================== + Hits 6230 6231 +1 - Misses 1891 1892 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

hugobuddel commented 2 weeks ago

Sorry codecov, I don't want to mock importlib.metadata in order to test this.