search

AstarVienna / ScopeSim

A telescope observation simulator for Python.
GNU General Public License v3.0
16 stars 10 forks source link

Add support for package and mode status keywords #509

Closed teutoburg closed 23 hours ago

teutoburg commented 6 days ago

Sibling of AstarVienna/irdb#201.

codecov[bot] commented 6 days ago

Codecov Report

Attention: Patch coverage is 29.41176% with 12 lines in your changes missing coverage. Please review.

Project coverage is 77.08%. Comparing base (86c3e1f) to head (c689b9e).

Files with missing lines Patch % Lines
scopesim/commands/user_commands.py 29.41% 12 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #509 +/- ## ========================================== - Coverage 77.16% 77.08% -0.09% ========================================== Files 66 66 Lines 8204 8218 +14 ========================================== + Hits 6331 6335 +4 - Misses 1873 1883 +10 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features:

teutoburg commented 6 days ago

Now codecough is complaining, perhaps we should put a status also in tests/mocks/basic_instrument/default.yaml to simulate all of this...

hugobuddel commented 6 days ago

Now codecough is complaining, perhaps we should put a status also in tests/mocks/basic_instrument/default.yaml to simulate all of this...

I think we should indeed test this, otherwise it will bite us at some point. Or it is implicitly tested through the IRDB I guess right? (Maybe we should add coverage support to ScopeSim_Data?)