Closed teutoburg closed 1 year ago
Patch coverage: 91.83%
and project coverage change: +0.13%
:tada:
Comparison is base (
bcf5590
) 78.80% compared to head (6cb4a2a
) 78.94%. Report is 2 commits behind head on dev_master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Great! LGTM.
A thought about renaming of mass2Mv()
to mass2absmag()
: it can also be useful to use absmag_from_mass()
, as the _from_
naming convention makes it easier to visually parse that code is correct than the _to_
convention. Compare:
my_mag = absmag_from_mass(my_mass)
...
my_mag = mass_to_absmag(my_mass)
In the first, the part of the function name that refers to the output of the function is close to where the output actually goes, and the part of the function name that refers to the input is close to the input of the function.
I've been using the _from_
convention since reading https://www.joelonsoftware.com/2005/05/11/making-wrong-code-look-wrong/
Nevertheless, the new name is an improvement over the original name (and perhaps more conventional then my suggestion), and this is just bikeshedding.
Mostly related to cluster functionality, see commit msgs for details.