AstarVienna / ScopeSim_Templates

GNU General Public License v3.0
2 stars 4 forks source link

Add calibration sources required by METIS #80

Closed teutoburg closed 5 months ago

teutoburg commented 6 months ago

Adds a basic pinhole mask on the basis of the already existing one for MICADO (and using the positions defined in #31), as well as a basic flat-field laser spectrum source.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.59%. Comparing base (fb9baa2) to head (b904a09).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev_master #80 +/- ## =========================================== Coverage 79.59% 79.59% =========================================== Files 44 44 Lines 2049 2049 =========================================== Hits 1631 1631 Misses 418 418 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

teutoburg commented 6 months ago

Also closes #31 (once complete)

hugobuddel commented 5 months ago

Just a note that https://github.com/AstarVienna/METIS_Simulations/issues/11 contains a figure of the spectrum with about 20 lines from the variable laser (if I interpret the figure correctly). So maybe we can also do about 20 lines by default (I recall I suggested about 10 before; that number was just pulled out of thin air). We would probably need to make the simulations to decide what the best setting of the laser would be.

Please tag me if you need specific input from me @teutoburg . I trust you to decide when this can be merged.

teutoburg commented 5 months ago

Just a note that AstarVienna/METIS_Simulations#11 contains a figure of the spectrum with about 20 lines from the variable laser (if I interpret the figure correctly). So maybe we can also do about 20 lines by default (I recall I suggested about 10 before; that number was just pulled out of thin air). We would probably need to make the simulations to decide what the best setting of the laser would be.

For some bizarre reason, anything above 6 lines results in, ... 2 lines. I've looked at it for a bit now and not sure why this is happening. Maybe they get too close together and that confuses Synphot? But I don't see why that might happen...

teutoburg commented 5 months ago

For some bizarre reason, anything above 6 lines results in, ... 2 lines. I've looked at it for a bit now and not sure why this is happening. Maybe they get too close together and that confuses Synphot? But I don't see why that might happen...

Nevermind, this was more float madness.....

teutoburg commented 5 months ago

I'll merge as soon as tests pass...