search

AstarVienna / skycalc_ipy

iPython version of skycalc_cli
GNU General Public License v3.0
4 stars 7 forks source link

Use https://etimecalret-002.eso.org #25

Closed hugobuddel closed 1 year ago

hugobuddel commented 1 year ago

Closes #24

codecov[bot] commented 1 year ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (227b8b9) 99.02% compared to head (0127f2d) 99.02%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #25 +/- ## ======================================= Coverage 99.02% 99.02% ======================================= Files 2 2 Lines 205 205 ======================================= Hits 203 203 Misses 2 2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

hugobuddel commented 1 year ago

It also raises the question what else has changed in skycalc_cli that we might want to propagate to our code/fork.

And it raises the question why we store the URL at all. We could also have skycalc_cli as a dependency of skycalc_ipy and fetch the url from there. Or maybe make this a proper wrapper around that package. But maybe there are good reasons not to do that.

I think we should also make a new release of skycalc_ipy, because otherwise everything is still broken. And perhaps update the minimum dependency for the packages that depend on skycalc_ipy.