Boolean output on the API call?

[stagg54]

Can we add a Passed? boolean output to the API call that is True if all tests results are either "Skipped" or "Passed"?

Right now I'm just parsing the string output (see below) and that seems rather inefficient.

Since it is simply adding an output, it shouldn't be a breaking change.

[stagg54]

I cloned the repo and was going to make a pullrequest, however there were some missing VIs (even after I installed the vipc).

See image.

[antsundq]

Right, yes that would make sense.

Would it make sense to make it a string? Then we could distinguish fails from errors. It would still show "Passed" if all tests are either passed or skipped.

Regarding the issues you see cloning the repo, it seems like I have some namespace issues I need to sort out. Will have a look at that when I find some time.

[stagg54]

Personally I would still prefer a boolean and I see the logic. It makes sense and is better than parsing the existing output string. I am all for it.

A question would be is a string the right answer? or would an enum be better? Either Pass, Fail or Error? If you want more details than that then you need to parse the more verbose output string?

Whichever one you decide is fine by me.

[antsundq]

Hey, sorry for the delay. This is now added to the API: It is in the version found here: https://github.com/Astemes/astemes-lunit/releases/tag/v1.7.6 Will post to VIPM in the near future.

[stagg54]

Awesome! Thank you!

-- Samuel Taggart LabVIEW Champion, DQMH Trusted Advisor CLA, CTD,CPI SAS Workshops sasworkshops.com 412-216-8789 On Nov 24, 2024 at 11:38 AM -0700, Anton Sundqvist @.***>, wrote:

Hey, sorry for the delay. This is now added to the API: image.png (view on web) It is in the version found here: https://github.com/Astemes/astemes-lunit/releases/tag/v1.7.6 Will post to VIPM in the near future. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>