AsteriskLabs / devise_google_authenticator

A Devise extension to allow your app to utilise Google's 2FA Mobile app
http://labs.asteriskinfosec.com.au/tag/devise_google_authenticator/
MIT License
216 stars 159 forks source link

fixed tests and bug when not signed in and accessing displayqr and resource_params without strong params #35

Open ThunderKey opened 10 years ago

ThunderKey commented 10 years ago

Some Tests failed because of a change from "Sign in" to "Log in" in devise. One Test failed, because the name of the field user_token is user_gauth_token, the attribute gauth_enable gets set to true in another test and the display_qrpath got called without being logged in, which lead to a problem that was solved in the DisplayqrController with adding ":force => true" to the authenticate#{resource_name}! call. Without the force it would not redirect to the login page because devise only redirects if it is not a DeviceController or force is true. The test also failed, because the user_gauth_token was not added in the own show.html.erb file. The last fix is a simple one to prevent resource_params to fail if you do not use strong params.