search

AsteriskLabs / devise_google_authenticator

A Devise extension to allow your app to utilise Google's 2FA Mobile app
http://labs.asteriskinfosec.com.au/tag/devise_google_authenticator/
MIT License
216 stars 159 forks source link

Use latest devise #58

Closed pjambet closed 5 years ago

pjambet commented 6 years ago

This will allow upgrades to rails 5 and ruby 2.5.0

zedtux commented 6 years ago

@pjambet are the tests passing on your branch?

pjambet commented 6 years ago

@zedtux Yes, I've been running this in production for a few weeks without any issues.

zedtux commented 6 years ago

I'm talking about the automated tests (minitest)

pjambet commented 6 years ago

Sorry, replied too quickly, my bad.

Tests don't even pass locally on upstream master, so I can't tell.

zedtux commented 6 years ago

Okay, so same on my side, thank you @pjambet for your answer 👍

pjambet commented 5 years ago

This thing has been opened for a while, and I don't need it anymore, so closing this.