AsteroidOSSync disables vibrate mode

AsteroidOS / AsteroidOSSync

Android application to synchronize a phone with a watch running asteroid-btsyncd.

GNU General Public License v3.0

101 stars 37 forks source link

AsteroidOSSync disables vibrate mode #79

Closed Rudloff closed 5 years ago

Rudloff commented 5 years ago

Hello,

I usually keep my phone in vibrate-only mode. But since 0.13, everytime I start AsteroidOSSync, it automatically enables my ringtone.

It is probably a side-effect of https://github.com/AsteroidOS/AsteroidOSSync/pull/68.

jrtberlin commented 5 years ago

Sorry, for the issue. This was a bug in 0.12 that shouldn't be in 0.13 (It should only do anything onConnect if you have enabled the checkbox)

Can you please share a few details, such as:

Android Version
Model number (of the phone)
Manufacturer (of the phone)

EDIT: It should only do that as a fall back (theoretically). This should be fixed in commit c4284ff. If you still have the issue please try to enable and disable the silent mode checkbox.

Rudloff commented 5 years ago

I am using Android 7.1.2 on a Fairphone 2.

If you still have the issue please try to enable and disable the silent mode checkbox.

This seems to have fixed the issue, thanks! (I had never enabled this option before.)

Edit: I spoke too soon. Vibrate mode is still disabled whenever my phone (dis)connects with my watch.

jrtberlin commented 5 years ago

Damn, I will try to reproduce the issue tomorrow.

jrtberlin commented 5 years ago

I could reproduce the issue. For some reason sometimes the Bluetooth connection resets during the pairing process and triggers the onDisconnect() function. The function lacked an if statement to check if silent mode is enabled and used the fallback.