search

AsteroidOS / asteroid-launcher

AsteroidOS launcher and Wayland compositor based on Qt5, QML and QtWayland via Lipstick.
Other
45 stars 34 forks source link

Fix 3x3 launcher margins and remove dead code #123

Closed beroset closed 1 year ago

beroset commented 1 year ago

This patch does a few things intended to fix issues and clean up the code a bit.

First, instead of using preferredHighlightBegin and preferredHighlightEnd and highlightRangeMode, we simply use header and footer and point to a square Item component that is half the size of a row. This fixes #122 .

Second, some dead code was removed: two unused Connections were removed, and the launcherColorOverride setting.

Third, the delegate for the grid was changed to a named Component and moved from inline. This helps readability. See https://doc.qt.io/qt-6/qml-qtquick-gridview.html#example-usage for the description of "An improved grid view" where a similar change was made in the example.

FlorentRevest commented 1 year ago

Lovely, thank you! :D one less thing holding back 2.0 🚀