search

AsteroidOS / asteroid-launcher

AsteroidOS launcher and Wayland compositor based on Qt5, QML and QtWayland via Lipstick.
Other
45 stars 34 forks source link

Fix #90 by making bluetooth agent round #91

Closed dodoradio closed 2 years ago

dodoradio commented 2 years ago

A very blunt fix for #90 - bluetooth dialog not being round on watches with non-square displays. There might be other elements with a similar issue, but I haven't run into them yet.

FlorentRevest commented 2 years ago

To be entirely future-proof, we should also use width: min(initialSize.width, initialSize.height) because for example minnow is wider than it is tall and this would still cause notifications whose proportions are off.

It was kind of the idea between Dims.w (width percentage) Dims.h (height percentage) and Dims.l (percentage of the shortest dimension of the screen) so we can draw circles of the dimension that fits in the screen. So maybe width: Dims.l(100) helps here ?

But to be fair I'm not sure if the btAgent top item is even centered (probably not?) so it sounds like changing the size of the top item will make the notification round but it will be positioned from the top left corner and lead to weird behaviors still ?

FlorentRevest commented 2 years ago

Merging this anyway because it's an improvement over the status quo but thanks for taking a look if the comments above are actual issues