search

AsteroidOS / asteroid-settings

Default settings app for AsteroidOS
GNU General Public License v3.0
9 stars 18 forks source link

Add support for disabling burn in protection. #36

Closed MagneFire closed 2 years ago

MagneFire commented 2 years ago

Checkout the main PR: https://github.com/AsteroidOS/asteroid-launcher/pull/69

Actually, it might be better to hide this option when DeviceInfo.preferBurnInProtection is set to false. If it is desired that this option is disabled by default (for example LCDs) then it doesn't make sense to show it anyway.

MagneFire commented 2 years ago

Had a discussion with @jrtberlin. We should change this implementation such that the burn in protection option should only be visible when actually needed (preferred).

This means that I'll change the option name from DeviceInfo.preferBurnInProtection to DeviceInfo.needsBurnInProtection and hide that option in the settings app when no burn in protection is needed (for LCDs).

MagneFire commented 2 years ago

The additional idea/change has now been applied, when a device doesn't need burn in protection techniques then the option isn't shown at all and disabled in asteroid-launcher.

FlorentRevest commented 2 years ago

Very cool, this is very often requested by our users :)

MagneFire commented 2 years ago

To be fair, I still need to disable burn in protection for watches that don't even need it. A quick glance at our supported watches indicates that the following don't need burn in protection (because they have an LCD): smelt, dory and tetra.