search

AsteroidOS / asteroid-settings

Default settings app for AsteroidOS
GNU General Public License v3.0
9 stars 18 forks source link

Eliminate the use of obsolete dbus-glib library #50

Closed beroset closed 2 years ago

beroset commented 2 years ago

This addresses issue #30 and removes the dependency on the obsolete dbus-glib library. Instead, it uses QDbus for somewhat smaller and cleaner code, but with one remaining issue, which is that the callback from the StepsUpdated signal from com.Meego.MainVolume2 service is never triggered. A workaround is to set the values explicitly within this code each time the volume is changed, but this does not allow the volume level display to be updated if it's done by some other application while the volume setting display is open.

beroset commented 2 years ago

Done and tested.

FlorentRevest commented 2 years ago

Oh no, apologies 🙉 this PR somehow slipped through I totally forgot about it. Please don't hesitate to remind me if I forget a PR, luckily I just stumbled upon it by luck.

This actually looks great, thanks a lot for all the cleanups PRs, very appreciated!