search

AsteroidOS / asteroid-settings

Default settings app for AsteroidOS
GNU General Public License v3.0
9 stars 18 forks source link

package automation in CMakeLists and vscode extension recommendations #62

Closed lepras closed 1 year ago

lepras commented 1 year ago

suggested in this and this comment.

I will take this PR as an example and do the same in other apps. Will wait till it is merged and changes are reviewed.

FlorentRevest commented 1 year ago

Note: I see in https://github.com/AsteroidOS/asteroidos.org/pull/220/commits that you added PR edit changes as an additional commit. For that other PR, it's not really a big deal because I can squash the PR into one single commit but here I would like to keep the two commits you created (one for the vscode recommended extensions and one for the cmakelist changes) so it would be great if you could spend a minute to learn git interactive rebase, git commit --amend and fixups. I know it's a bit unpleasant the first time but I promise it's worth it since it's an important skill to contribute to open source projects ;)

FlorentRevest commented 1 year ago

I see you squashed the fix for vscode extensions recommendations into the wrong commit :/ you can review your commits locally yourself using git log -c and make sure they are self-coherent

Anyway... I don't want to torture you one more time so I'll squash the two commits into one but that's a bad practice. If you get a chance. For the other repos, try to make one commit per file