AsteroidOS / meta-asteroid

OpenEmbedded layer that provides the basis of AsteroidOS
GNU General Public License v2.0
78 stars 45 forks source link

Fix OPENSSL_LINKING_MODE in qtbase #115

Closed beroset closed 2 years ago

beroset commented 2 years ago

By default, qtbase 5 attempts to load libssl-1_1 and libcrypto-1_1 as can be seen in this function: https://github.com/qt/qtbase/blob/v5.15.4-lts-lgpl/src/network/ssl/qsslsocket_openssl_symbols.cpp#L670

The problem is that those versions are old and don't handle ssl very well. This Javascript code was being called in response to a button press in QML, but the request failed every time.

function getWeatherForecast(lat, lon, apikey) {
    const xhttp = new XMLHttpRequest();
    xhttp.onreadystatechange = function() {
        if (xhttp.readyState == XMLHttpRequest.DONE && xhttp.status == 200) {
            updateForecast(xhttp.responseText.toString());
        } else {
            console.log("readystate: ", xhttp.readyState);
            console.log("HTTP status: ", xhttp.status);
        }
    };
    var url = "https://asteroidos.org/CNAME";
    console.log("url: ", url);
    xhttp.open("GET", url);
    xhttp.send();
}

See https://github.com/meta-qt5/meta-qt5/issues/437 for both a very similar report and the suggested fix that this patch incorporates.

Signed-off-by: Ed Beroset beroset@ieee.org

MagneFire commented 2 years ago

Looks good to me :+1: