lcd-tools: remove `COMPATIBLE_MACHINE`

AsteroidOS / meta-asteroid

OpenEmbedded layer that provides the basis of AsteroidOS

GNU General Public License v2.0

78 stars 45 forks source link

lcd-tools: remove `COMPATIBLE_MACHINE` #142

Closed dodoradio closed 1 year ago

dodoradio commented 1 year ago

koi has now been added as to meta-smartwatch. support for it has existed in lcd-tools for a while now, so now seems like an appropriate time to declare it compatible.

MagneFire commented 1 year ago

Hmm, PR looks fine but the COMPATIBLE_MACHINE part might not be needed since we already perform a runtime check for compatibility.

What's your opinion on this?

dodoradio commented 1 year ago

yep, seems reasonable. The tool won't be installed on unsupported platforms by default, and it won't break anything if it is installed. Sounds good to me - should I remake this PR to remove the COMPATIBLE_MACHINE line?

MagneFire commented 1 year ago

Looks good, thanks for the quick update!