search

AsteroidOS / meta-smartwatch

OpenEmbedded layer that provides support for various smartwatches.
25 stars 18 forks source link

emulator: Move qemux86-specific changes into separate machine meta layer #239

Open casept opened 8 months ago

casept commented 8 months ago

Previously, qemux86-related changes were strewn all over meta-asteroid, which went against the way all other machines are handled.

This change creates a new "smartwatch" machine, called emulator. It inherits most machine configuration from openembedded's qemux86 machine.

The patches, configs etc. are basically the same as they were in meta-asteroid, the interesting change is the creation of a dedicated machine.conf.

Also see https://github.com/AsteroidOS/meta-asteroid/pull/188 for the removal from meta-asteroid and https://github.com/AsteroidOS/asteroid/pull/281 for renaming in the build script.

casept commented 8 months ago

Oops, looks like I managed to break mouse support. Converting back to draft until that's fixed

FlorentRevest commented 6 months ago

I see this is still marked as draft, presumably because you haven't gotten a chance to fix mouse support, is that right ?

This is the reason why I have not commented on https://github.com/AsteroidOS/asteroid/pull/281 and https://github.com/AsteroidOS/meta-asteroid/pull/188 and this one yet.

FWIW, the changes look good to me overall. Are you sure that mouse support even worked before your refactoring ? If not, that's a strict improvement and we can move forward with it anyway. If something did break though, it would be good to figure it out before merging :)

beroset commented 6 months ago

I think the idea of this is good. One thing that I wonder about is whether, by renaming from qemux86 to emulator if we might lose some of the Yocto functionality that uses qemu. See https://docs.yoctoproject.org/dev-manual/qemu.html

casept commented 6 months ago

Yes, I'm sure that the mouse support does work on the current master and is broken by my PR.

I think I've managed to narrow it down to a strange configuration installation issue - for whatever reason, when I try to override the search path for asteroid-launcher-configs in a .bbappend in meta-emulator to install the proper configs, bitbake silently ignores the changes. If I make the prepend unconditional it works, but obviously breaks other machines.