AsteroidOS / starship

SailfishOS synchronization app for AsteroidOS.
GNU General Public License v3.0
22 stars 12 forks source link

Convert Starship to support CMake #24

Closed GeoffTearle closed 2 years ago

GeoffTearle commented 2 years ago

This PR converts Starship over to the CMake build system, to bring it into alignment with asteroidsyncservice and other AsteroidOS projects.

This PR is dependent on https://github.com/AsteroidOS/asteroidsyncservice/pull/54 first being merged, so that the submodule can then be updated.

FlorentRevest commented 2 years ago

Overall looks good except the git log should be cleaned up and icons//harbour-starship.png should be rasterizations of icons//harbour-starship.svg

FlorentRevest commented 2 years ago

Overall looks good except the git log should be cleaned up and icons//harbour-starship.png should be rasterizations of icons//harbour-starship.svg

GeoffTearle commented 2 years ago

Sorry all, I managed to accidentally close this PR while restructuring the git log :sweat_smile: , so I've recreated it here https://github.com/AsteroidOS/starship/pull/25