search

AsteroidOS / starship

SailfishOS synchronization app for AsteroidOS.
GNU General Public License v3.0
22 stars 12 forks source link

Convert Starship to support CMake #25

Closed GeoffTearle closed 1 year ago

GeoffTearle commented 2 years ago

Apologies, I somehow managed to close my previous PR so I have recreated it here

This PR converts Starship over to the CMake build system, to bring it into alignment with asteroidsyncservice and other AsteroidOS projects.

This PR is dependent on https://github.com/AsteroidOS/asteroidsyncservice/pull/54 first being merged, so that the submodule can then be updated.

FlorentRevest commented 2 years ago

This now looks good to me but the PR it depends on https://github.com/AsteroidOS/asteroidsyncservice/pull/54 should also have a cleaner git log (without the merge commits etc...)

GeoffTearle commented 2 years ago

This now looks good to me but the PR it depends on AsteroidOS/asteroidsyncservice#54 should also have a cleaner git log (without the merge commits etc...)

Sorry for the long tail on this, I'll try to get it all cleaned up this weekend 😄

eLtMosen commented 2 years ago

Sorry for the long tail on this,

No reason to apologize at all! So great to see you contributing. As sailfish users, we are accustomed to waits, aren't we :D Thank you again.

GeoffTearle commented 1 year ago

losing this for now, as its massively out of date. Will attempt to re-open in the future when I have a bit more time to work on it