search

AsteroidOS / unofficial-watchfaces

Database of community-made watchfaces for AsteroidOS.
51 stars 32 forks source link

Simplify changing script for use with qemux86 target. #40

Closed beroset closed 2 years ago

beroset commented 2 years ago

Using deploy.sh with the qemux86 target requires changing the port and address for the ssh and scp commands. This simplifies that change by extracting those attributes as shell variables. The function is unchanged from the original. Fixes #38.

Signed-off-by: Ed Beroset beroset@ieee.org

FlorentRevest commented 2 years ago

What about adding a --qemu argument that would set these two variables to the sensible qemu values? :)

beroset commented 2 years ago

What about adding a --qemu argument that would set these two variables to the sensible qemu values? :)

I have implemented this a done considerable refactoring. So, should I create a new branch and PR or try to do an interactive rebase? Or.. just add another commit?

FlorentRevest commented 2 years ago

In the case where you only need to modify the most recent commit there’s an even easier way than interactive rebases git commit -amend

Have a look at the second paragraph of https://ohnogit.com/

The answer is almost never to create a new PR :) just modify your existing branch and then use git push —force (this will let you rewrite your history)

I realize this seems intimidating at first but you’ll quickly get the hang of it and this will make your future contributions a lot easier ;)

beroset commented 2 years ago

OK, that took a few tries, but I think I've got it.

FlorentRevest commented 2 years ago

Great job :) thanks a lot