search

AsteroidOS / unofficial-watchfaces

Database of community-made watchfaces for AsteroidOS.
51 stars 32 forks source link

Add static time to loader #47

Closed beroset closed 2 years ago

beroset commented 2 years ago

Create a way for the user to statically set time or have it track system time. May help fix #43

Signed-off-by: Ed Beroset beroset@ieee.org

beroset commented 2 years ago

The "feature slider" normally does nothing but provides a way for the watchface designer to play with the settings of things other than date and time (e.g. battery charge indication) by temporarily rewriting the code to fetch featureSlider.value and scaling/offsetting if desired (it's a floating point value from 0.0 to 1.0).

beroset commented 2 years ago

The review was very helpful, and I have addressed all of the named issues and two additional ones: all of the interface strings are now wrapped in qsTr() and a tooltip was added to explain the use of featureSlider to the user.

beroset commented 2 years ago

No need to apologize for a picky review. That's how to make sure the code quality remains high and that consistency is maintained.

FlorentRevest commented 2 years ago

Excellent, thank you !