search

AsteroidOS / unofficial-watchfaces

Database of community-made watchfaces for AsteroidOS.
51 stars 32 forks source link

Fix binary digital #60

Closed eLtMosen closed 2 years ago

eLtMosen commented 2 years ago

During development of the watchfacePage, it was discovered that binary-digital displayed wrong.

Current state:

binary-digital-round

Fixed after commit https://github.com/eLtMosen/unofficial-watchfaces/commit/a361d9813a4617669deec61b9ffa081d34347490

binary-digital-round-fixed

FlorentRevest commented 2 years ago

Great :) A tip for the future: your commit titles will be read in the context of the git log for the entire repository. In that context it's hard to know that "Remove unused imports" refer to one specific watchface. A common pattern in repositories that contain multiple components is to prefix commit titles with the name of the affected component. For example: "binary-digital: Remove unused imports" or depending on the convention "[binary-digital] Remove unused imports"