search

Astoundify / marketify

[DEPRECATED] A Digital Marketplace and Digital Store For Easy Digital Downloads
0 stars 0 forks source link

FactWP 3.x Support #731

Closed spencerfinnell closed 7 years ago

spencerfinnell commented 7 years ago

https://y1.r-ev.com/products/

The Salvattore column script isn't working with it.

https://github.com/Astoundify/marketify/blob/8a01457fec763aba5ea37a91def85e4d39a9720f/inc/integrations/facetwp/js/facetwp.coffee

Action might just need to be updated.

turtlepod commented 7 years ago

Right now I have no idea how this works.

turtlepod commented 7 years ago

Apparently everything is broken (probably). the script is not even loaded (?)

turtlepod commented 7 years ago

This code is not windows server compatible:

$pieces = explode( '/', $this->directory );
spencerfinnell commented 7 years ago

Interesting don't think I've seen that before. Can you make a PR for that and I'll fix the columns?

It just needs DIRECTORY_SEPARATOR right? http://php.net/manual/en/dir.constants.php

turtlepod commented 7 years ago

I'll delete my branch.

turtlepod commented 7 years ago

(not sure if it's correct) I think facetwp-template class should be added as wrapper of edd shortcode (because of the pagination)

spencerfinnell commented 7 years ago

This might be a good time to just do #723

turtlepod commented 7 years ago

I never use flexbox :) I'll do some reading tomorrow.