Closed StreakyCobra closed 7 years ago
I'm actually going to not merge this because there's other things that need to happen. But thank you very much for reminding me I need to do them and submitting a PR.
Ok :+1:
Side note: Do action like this very carefully, i.e. closing valid Pull Request saying «I'm going to do it myself for/because …», especially with newcomers.
It is what makes the difference between newcomers to stay with "Nice, let's try another contribution", and making newcomers to leave with "Ok, so do it by yourself, bye". Even if it is obvious and really simple changes like this one. Contributors, especially newcomers, took a lot of time to: enter and understand the code, fork the project, clone it locally, create a branch, make a change, write a commit message, push back and open a pull-request. By accepting a PR, you recognize the time, the work and the interest they have put on your project. This will also show on their GitHub profile they have contributed to your project, what is a nice reward for them.
In a case like this one, you can simply cherry-pick the commit and do your other changes in an additional commit just behind. It happens that sometime a PR is not perfect. If it's code-wise, simply ask for changes during the PR review, or accept the PR and fix it in an additional commit. If it is commit-message-wise, I happened to have reworded some when cherry-picking, but always by keeping the original author.
In this case don't worry :smile: I'm used to open source project contributions and I've already contributed to enough of them for not having to care about one particular contribution.
As indicated by this Trace when xonsh is run with
$XONSH_DEBUG=1
Signed-off-by: Fabien Dubosson fabien.dubosson@gmail.com