AstraZeneca / chemicalx

A PyTorch and TorchDrug based deep learning library for drug pair scoring. (KDD 2022)

https://chemicalx.readthedocs.io

Apache License 2.0

708 stars 87 forks source link

Re-enable flake8 check #26

Closed cthoyt closed 2 years ago

cthoyt commented 2 years ago

Summary

This PR applies black/isort and re-enables flake8 checking. It adds the missing skip_install=true flag in flake8 that makes it not have to worry about installing the complicated deps.

[ ] Code passes all tests
[ ] Unit tests provided for these changes
[ ] Documentation and docstrings added for these changes

cthoyt commented 2 years ago

@benedekrozemberczki the fact that the mypy check was disabled is also an issue, since the current feature loader has a lot of issues in its structure that mypy would have indeed caught. Maybe best to do changes in PRs from now so this is checked externally?